Documentation

Markers

Table of Contents

Sources/Actions/Admin/ACP.php 1
Sources/Actions/Admin/Languages.php 1
Sources/Actions/Admin/Maintenance.php 1
Sources/Actions/Admin/Smileys.php 2
Sources/Actions/Admin/Subscriptions.php 3
Sources/Actions/Calendar.php 1
Sources/Actions/Feed.php 1
Sources/Actions/Groups.php 1
Sources/Actions/Like.php 1
Sources/Actions/MarkRead.php 1
Sources/Actions/Moderation/Groups.php 1
Sources/Actions/Profile/Export.php 1
Sources/Actions/Recent.php 1
Sources/Actions/RequestMembers.php 1
Sources/Actions/Search2.php 1
Sources/Actions/TopicPrint.php 1
Sources/Actions/Unread.php 1
Sources/Board.php 1
Sources/Cache/CacheApi.php 1
Sources/Cache/CacheApiInterface.php 2
Sources/Category.php 1
Sources/Db/APIs/PostgreSQL.php 1
Sources/Db/DatabaseApi.php 1
Sources/Db/DatabaseApiInterface.php 3
Sources/MailAgent/MailAgent.php 1
Sources/PackageManager/PackageManager.php 1
Sources/Parsers/BBCodeParser.php 1
Sources/PersonalMessage/Received.php 1
Sources/PersonalMessage/Search.php 3
Sources/Subs-Compat.php 16
Sources/Tasks/ApprovePost_Notify.php 1
Sources/Tasks/ApproveReply_Notify.php 1
Sources/Tasks/Birthday_Notify.php 1
Sources/Tasks/Buddy_Notify.php 1
Sources/Tasks/CreateAttachment_Notify.php 1
Sources/Tasks/CreatePost_Notify.php 1
Sources/Tasks/DailyMaintenance.php 1
Sources/Tasks/EventNew_Notify.php 1
Sources/Tasks/ExportProfileData.php 1
Sources/Tasks/FetchCalendarSubscriptions.php 1
Sources/Tasks/FetchSMFiles.php 1
Sources/Tasks/GenericScheduledTask.php 1
Sources/Tasks/GenericTask.php 1
Sources/Tasks/GroupAct_Notify.php 1
Sources/Tasks/GroupReq_Notify.php 1
Sources/Tasks/Likes_Notify.php 1
Sources/Tasks/MemberReport_Notify.php 1
Sources/Tasks/MemberReportReply_Notify.php 1
Sources/Tasks/MsgReport_Notify.php 1
Sources/Tasks/MsgReportReply_Notify.php 1
Sources/Tasks/PaidSubs.php 1
Sources/Tasks/PruneLogTopics.php 1
Sources/Tasks/Register_Notify.php 1
Sources/Tasks/RemoveOldDrafts.php 1
Sources/Tasks/RemoveTempAttachments.php 1
Sources/Tasks/RemoveTopicRedirects.php 1
Sources/Tasks/SendDigests.php 1
Sources/Tasks/UpdateTldRegex.php 1
Sources/Tasks/UpdateUnicode.php 1
Sources/Tasks/WeeklyMaintenance.php 1
Sources/User.php 1
Sources/Verifier.php 1
vendor/symfony/yaml/Tests/DumperTest.php 1
vendor/symfony/yaml/Tests/ParserTest.php 1

ACP.php

Type Line Description
TODO 805 see rev. 10406 from 2.1-requests

Languages.php

Type Line Description
TODO 1648 This function could be two functions?

Maintenance.php

Type Line Description
TODO 1463 refactor

Smileys.php

Type Line Description
TODO 2170 to be moved to Subs-Smileys?
TODO 2220 to be moved to Subs-Smileys?

Subscriptions.php

Type Line Description
TODO 2017 This appears to be unused. Remove it?
TODO 2178 refactor away
TODO 2213 refactor outta here

Calendar.php

Type Line Description
TODO 601 .... allow for week or month export files as well?

Feed.php

Type Line Description
TODO 565 get the list of members from Subs-Members.

Groups.php

Type Line Description
TODO 220 use SMF\ItemList

Like.php

Type Line Description
TODO 69 Do delete, insert, and count really need to be sub-actions? They are never used as sub-actions in practice. Instead, they are only ever called internally by the like() method. Moreover, the control flow regarding hooks, etc., assumes that they are only called by like().

MarkRead.php

Type Line Description
TODO 187 Should this be a separate action?

Groups.php

Type Line Description
TODO 119 use SMF\ItemList

Export.php

Type Line Description
TODO 37 Add CSV, JSON as other possible export formats besides XML and HTML?

Recent.php

Type Line Description
TODO 251 Break this up further.

RequestMembers.php

Type Line Description
TODO 34 This is 100% obsolete, but was never officially deprecated. Remove?

Search2.php

Type Line Description
TODO 78 Break this up into separate protected functions.

TopicPrint.php

Type Line Description
TODO 41 Rewrite to use Msg::get() in order to reduce memory load?

Unread.php

Type Line Description
TODO 342 Break this up further.

Board.php

Type Line Description
TODO 1148 Move this? It's not really related to boards.

CacheApi.php

Type Line Description
TODO 336 Add a reference to Utils::$context['instances'] as well?

CacheApiInterface.php

Type Line Description
TODO 48 Separate existence checking into its own method
TODO 61 Separate deletion into its own method

Category.php

Type Line Description
TODO 31 Make better use of this class in BoardIndex.php.

PostgreSQL.php

Type Line Description
TODO 114 This never seem to be used. Remove it?

DatabaseApi.php

Type Line Description
TODO 141 Use auto-detect for MySQL.

DatabaseApiInterface.php

Type Line Description
TODO 136 Use this for updating topics, maintenance, repairing boards, etc.
TODO 197 PostgreSQL requires a $result param, not a $connection.
TODO 330 why is this needed for?

MailAgent.php

Type Line Description
TODO 201 Add a reference to Utils::$context['instances'] as well?

PackageManager.php

Type Line Description
TODO 108 Add a reference to Utils::$context['instances'] as well?

BBCodeParser.php

Type Line Description
TODO 1906 Should this respect guest_hideContacts?

Received.php

Type Line Description
TODO 34 Rename the pm_recipients table to pm_received. A recipient is a person who receives something, not the thing received, so the table name is misleading.

Search.php

Type Line Description
TODO 35 Allow searching in the sent items folder.
TODO 431 Why not do this the same way as in SearchApi?
TODO 90 Add more here?

Subs-Compat.php

Type Line Description
TODO 69 see rev. 10406 from 2.1-requests
TODO 95 see rev. 10406 from 2.1-requests
TODO 285 refactor this silly superglobals use...
TODO 735 lazy loading. Uses ManageSettings language file
TODO 1083 refactor
TODO 1175 look at this
TODO 2918 Add CSV, JSON as other possible export formats besides XML and HTML?
TODO 3245 This function needs to be split up properly.
TODO 3728 .... allow for week or month export files as well?
TODO 4541 this should be a simple dispatcher....
TODO 4717 refactor this...
TODO 5604 Add special handling for objects?
TODO 5715 see if it's better in Subs-Graphics, but one step at the time. Uses getimagesize() to determine the size of a file. Attempts to connect to the server first so it won't time out.
TODO 9635 get rid of reading $_REQUEST directly
TODO 10093 shouldn't this be in topic
TODO 10521 Different file?

ApprovePost_Notify.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

ApproveReply_Notify.php

Type Line Description
TODO 39 PHP 8.2: This can be changed to return type: true.

Birthday_Notify.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

Buddy_Notify.php

Type Line Description
TODO 35 PHP 8.2: This can be changed to return type: true.

CreateAttachment_Notify.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

CreatePost_Notify.php

Type Line Description
TODO 102 PHP 8.2: This can be changed to return type: true.

DailyMaintenance.php

Type Line Description
TODO 37 PHP 8.2: This can be changed to return type: true.

EventNew_Notify.php

Type Line Description
TODO 36 PHP 8.2: This can be changed to return type: true.

ExportProfileData.php

Type Line Description
TODO 881 PHP 8.2: This can be changed to return type: true.

FetchCalendarSubscriptions.php

Type Line Description
TODO 36 PHP 8.2: This can be changed to return type: true.

FetchSMFiles.php

Type Line Description
TODO 37 PHP 8.2: This can be changed to return type: true.

GenericScheduledTask.php

Type Line Description
TODO 31 PHP 8.2: This can be changed to return type: true.

GenericTask.php

Type Line Description
TODO 31 PHP 8.2: This can be changed to return type: true.

GroupAct_Notify.php

Type Line Description
TODO 39 PHP 8.2: This can be changed to return type: true.

GroupReq_Notify.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

Likes_Notify.php

Type Line Description
TODO 36 PHP 8.2: This can be changed to return type: true.

MemberReport_Notify.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

MemberReportReply_Notify.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

MsgReport_Notify.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

MsgReportReply_Notify.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

PaidSubs.php

Type Line Description
TODO 40 PHP 8.2: This can be changed to return type: true.

PruneLogTopics.php

Type Line Description
TODO 37 PHP 8.2: This can be changed to return type: true.

Register_Notify.php

Type Line Description
TODO 38 PHP 8.2: This can be changed to return type: true.

RemoveOldDrafts.php

Type Line Description
TODO 34 PHP 8.2: This can be changed to return type: true.

RemoveTempAttachments.php

Type Line Description
TODO 35 PHP 8.2: This can be changed to return type: true.

RemoveTopicRedirects.php

Type Line Description
TODO 33 PHP 8.2: This can be changed to return type: true.

SendDigests.php

Type Line Description
TODO 39 PHP 8.2: This can be changed to return type: true.

UpdateTldRegex.php

Type Line Description
TODO 32 PHP 8.2: This can be changed to return type: true.

UpdateUnicode.php

Type Line Description
TODO 555 PHP 8.2: This can be changed to return type: true.

WeeklyMaintenance.php

Type Line Description
TODO 35 PHP 8.2: This can be changed to return type: true.

User.php

Type Line Description
TODO 583 This doesn't appear to be used anywhere.

Verifier.php

Type Line Description
TODO 192 BEFORE COMMITTING: Can't return errors from constructor.

DumperTest.php

Type Line Description
TODO 125 } else {

ParserTest.php

Type Line Description
TODO 1779 } else {

Search results